Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#269 closed defect (fixed)

Offset calculation in DbMetadataSource class is wrong

Reported by: Dirk Daems Owned by: Piero Campalani
Priority: major Milestone: 8.4
Component: petascope Version: 8.3
Keywords: Cc:
Complexity: Medium

Description

When the offset is not specified in the ps_crsdetails table it is calculated in the petascope.core.DbMetadataSource class. However this calculation is not correct:

  if (o1 == null && o2 == null) {
    o1 = (h1 - l1) / (double) (x1 - x0);
    o2 = (h2 - l2) / (double) (y1 - y0);
    ...
  }

Should be:

  if (o1 == null && o2 == null) {
    o1 = (h1 - l1) / (double) (x1 - x0 + 1);
    o2 = (h2 - l2) / (double) (y1 - y0 + 1);
    ...
  }

Change History (5)

comment:1 by Dimitar Misev, 11 years ago

Owner: changed from Dimitar Misev to Piero Campalani
Status: newassigned

Thanks for reporting it Dirk, we'll look at it!

comment:2 by Piero Campalani, 11 years ago

We are probably talking about the problem fixed in:

commit 4a24f9539ff04491ca290cb98b2532b7af3fe3e1
Author: Piero Campalani <cmppri@unife.it>
Date:   Fri Dec 7 17:05:43 2012 +0100

    Fix resolution evaluation for coverages.

Dirk, please let us know if we can close this one.

comment:3 by Dimitar Misev, 11 years ago

In other words, please pull the latest rasdaman from the git repository.

comment:4 by Piero Campalani, 11 years ago

Resolution: fixed
Status: assignedclosed

comment:5 by Dirk Daems, 11 years ago

OK, seems to be fixed!

Note: See TracTickets for help on using tickets.