petascope.wcps.* packages to use String constants

[Piero Campalani]

All String constants used by the WCPS should be collected in one place.

For instance:

• petascope.wcps.grammar.NumericScalarExpr.java

          if (op.equals("sqrt")) {
              function = "numericSqrt";
  

• petascope.wcps.server.core.NumericScalarExpr.java

          if (name.equals("numericSqrt")) {
              op = "sqrt";
  

Mind ([1]):
Rule 11: The names of constants must be all uppercase letters, words must be separated by underscores ("_").

[1] ​http://rasdaman.eecs.jacobs-university.de/trac/rasdaman/wiki/CodeGuideRules

[Dimitar Misev]

So Alireza, basically you go through the code in petascope.wcps.* and collect all literals into constants on one place, maybe in petascope.util.WCPSConstants

[Piero Campalani]

Right, or either distributed inside each of the sources in petascope.wcps.grammar, then let the methods in petascope.wcps.server.core refer to them.

[Dimitar Misev]

Can we close it Ali? I saw a few patches, is it completed?

[Alireza]

Working on it. Few files remained.

[Dimitar Misev]

I suppose it can be closed?