Memory Leaks

[Georg Semmler]

Using gcc-asan while debugging my own c++-code (which uses rasdamans c++ interface) i discovered a few memory leaks in raslib, rasodmg and rnprotocol.

[Georg Semmler]

This is not closed.

==32529==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 1708 byte(s) in 52 object(s) allocated from:
    #0 0x7ff715d3a76f in strdup (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x6276f)
    #1 0x11553f0 in r_Minterval::get_string_representation() const rasdaman/raslib/minterval.cc:851

Direct leak of 364 byte(s) in 52 object(s) allocated from:
    #0 0x7ff715d3a76f in strdup (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x6276f)
    #1 0x110478f in r_OQL_Query::operator<<(r_GMarray&) rasdaman/rasodmg/oqlquery.cc:368

Direct leak of 208 byte(s) in 13 object(s) allocated from:
    #0 0x7ff715d718b2 in operator new(unsigned long) (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x998b2)
    #1 0x11345f6 in RnpClientComm::RnpClientComm(char const*, int) ../rnprotocol/rnpclientcomm.cc:57

Direct leak of 13 byte(s) in 13 object(s) allocated from:
    #0 0x7ff715d709aa in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x989aa)
    #1 0x11335f4 in RnpClientComm::setStorageFormat(r_Data_Format, char const*) ../rnprotocol/rnpclientcomm.cc:1060

Direct leak of 13 byte(s) in 13 object(s) allocated from:
    #0 0x7ff715d709aa in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x989aa)
    #1 0x1133674 in RnpClientComm::setTransferFormat(r_Data_Format, char const*) ../rnprotocol/rnpclientcomm.cc:1082

Indirect leak of 1248 byte(s) in 13 object(s) allocated from:
    #0 0x7ff715d709aa in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x989aa)
    #1 0x1174f4c in r_Parse_Params::add(char const*, void*, r_Parse_Params::parse_param_type) rasdaman/raslib/parseparams.cc:83

SUMMARY: AddressSanitizer: 3554 byte(s) leaked in 156 allocation(s).

[Dimitar Misev]

How do we reproduce.. can you give more details?

[Dimitar Misev]

… due to lack of information on how to reproduce.

[Georg Semmler]

Steps to reproduce: Compile rasdaman with -fsanitize=address or -fsanitize=leak using a recent version of gcc or clang. See ​https://github.com/google/sanitizers/wiki/AddressSanitizer
Or simply lookup the source code location listed in comment 2. Most leaks are easy to spot. For example:

• ​http://rasdaman.org/browser/applications/rasgeo/wms-import/inittools/initpyramid.cc#L705
• ​http://rasdaman.org/browser/rasodmg/oqlquery.cc#L368
• ​http://rasdaman.org/browser/mddmgr/mddcoll.cc#L523
• ​http://rasdaman.org/browser/rnprotocol/rnpclientcomm.cc#L1096
• …

I've submitted a patch some time ago, that fixed some of those. It got rejected those days. I don't remember exactly why. If I remember correcty it was because I changed also some of the old unsafe str-functions to the safer strn ones.
​http://rasdaman.org/patchmanager/rejected?patchop=Download+Selected-1687

[Dimitar Misev]

Ok I thought you had a client program and identified the leaks with valgrind, so I was hoping you can attach the client code. Thanks for taking the time to provide more information.

[Dimitar Misev]

It's been fixed already.