Opened 10 years ago
Closed 8 years ago
#836 closed defect (fixed)
Change PetascopeInterface parent
Reported by: | Vlad Merticariu | Owned by: | Bang Pham Huu |
---|---|---|---|
Priority: | major | Milestone: | 9.3 |
Component: | petascope | Version: | development |
Keywords: | Cc: | ||
Complexity: | Medium |
Description
Refactor PetascopeInterface to use the functionality for CORS request available in CORSHttpServlet class, once available.
Change History (13)
comment:1 by , 10 years ago
Component: | undecided → petascope |
---|---|
Milestone: | → 9.1 |
comment:3 by , 9 years ago
Milestone: | 9.1 → Future |
---|
comment:4 by , 8 years ago
Milestone: | Future → 9.3 |
---|---|
Owner: | changed from | to
Status: | new → assigned |
Type: | defect → enhancement |
this is not fixed yet with change in PetascopeInterface to "extends CORSHttpServlet", I think I will take it.
comment:5 by , 8 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
patch was accepted, close ticket.
follow-up: 7 comment:6 by , 8 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Type: | enhancement → defect |
The patch broke CORS functionality.
You need to call super.doGet() in PetascopeInterface.doGet() before doing anything else in the function
comment:7 by , 8 years ago
Replying to mdumitru:
The patch broke CORS functionality.
You need to call super.doGet() in PetascopeInterface.doGet() before doing anything else in the function
cool, I will make a fix for it from your hint now.
follow-up: 9 comment:8 by , 8 years ago
There was a test in the patch, what is it testing if not the CORS functionality??
comment:9 by , 8 years ago
Replying to dmisev:
There was a test in the patch, what is it testing if not the CORS functionality??
it simulate a request from a random host to Petascope and check in the HTTP header, it has the "Allow origin: *".
follow-up: 12 comment:10 by , 8 years ago
But obviously that test doesn't work correctly if Alex says the CORS functionality is broken now.
comment:12 by , 8 years ago
Replying to dmisev:
But obviously that test doesn't work correctly if Alex says the CORS functionality is broken now.
ok, I will give more time to make the test correctly.
comment:13 by , 8 years ago
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
the patch was accepted, thanks.
Vlad please set milestone and component when you open tickets!