Opened 10 years ago

Closed 8 years ago

#836 closed defect (fixed)

Change PetascopeInterface parent

Reported by: Vlad Merticariu Owned by: Bang Pham Huu
Priority: major Milestone: 9.3
Component: petascope Version: development
Keywords: Cc:
Complexity: Medium

Description

Refactor PetascopeInterface to use the functionality for CORS request available in CORSHttpServlet class, once available.

Change History (13)

comment:1 by Dimitar Misev, 10 years ago

Component: undecidedpetascope
Milestone: 9.1

Vlad please set milestone and component when you open tickets!

comment:2 by Dimitar Misev, 9 years ago

can be closed?

comment:3 by Dimitar Misev, 9 years ago

Milestone: 9.1Future

comment:4 by Bang Pham Huu, 8 years ago

Milestone: Future9.3
Owner: changed from Vlad Merticariu to Bang Pham Huu
Status: newassigned
Type: defectenhancement

this is not fixed yet with change in PetascopeInterface to "extends CORSHttpServlet", I think I will take it.

comment:5 by Bang Pham Huu, 8 years ago

Resolution: fixed
Status: assignedclosed

patch was accepted, close ticket.

comment:6 by Alex Dumitru, 8 years ago

Resolution: fixed
Status: closedreopened
Type: enhancementdefect

The patch broke CORS functionality.
You need to call super.doGet() in PetascopeInterface.doGet() before doing anything else in the function

in reply to:  6 comment:7 by Bang Pham Huu, 8 years ago

Replying to mdumitru:

The patch broke CORS functionality.
You need to call super.doGet() in PetascopeInterface.doGet() before doing anything else in the function

cool, I will make a fix for it from your hint now.

comment:8 by Dimitar Misev, 8 years ago

There was a test in the patch, what is it testing if not the CORS functionality??

in reply to:  8 comment:9 by Bang Pham Huu, 8 years ago

Replying to dmisev:

There was a test in the patch, what is it testing if not the CORS functionality??

it simulate a request from a random host to Petascope and check in the HTTP header, it has the "Allow origin: *".

comment:10 by Dimitar Misev, 8 years ago

But obviously that test doesn't work correctly if Alex says the CORS functionality is broken now.

comment:11 by Dimitar Misev, 8 years ago

I mean the test still passes, so it's incorrect.

in reply to:  10 comment:12 by Bang Pham Huu, 8 years ago

Replying to dmisev:

But obviously that test doesn't work correctly if Alex says the CORS functionality is broken now.

ok, I will give more time to make the test correctly.

comment:13 by Bang Pham Huu, 8 years ago

Resolution: fixed
Status: reopenedclosed

the patch was accepted, thanks.

Note: See TracTickets for help on using tickets.