Opened 11 years ago

Closed 8 years ago

#486 closed enhancement (fixed)

Patch Manager to handle newline in header line

Reported by: abeccati Owned by: Dimitar Misev
Priority: minor Milestone: Future
Component: patch_manager Version: 8.5
Keywords: patchmanager Cc:
Complexity: Medium

Description (last modified by abeccati)

Patch Manager shows patch as pending even if it is applied when a newline is present in the header line.

Since common practice calls for the ability to provide more detail in a commit message than a single line this needs to be addressed by enhancing the patch manager.

Sample commit message:

ticket:000 Fixed problem with foo

Foo now uses bar as support function to work properly...
...

Change History (7)

comment:1 by Dimitar Misev, 11 years ago

Status: newassigned

Just make proper sentences, you don't need to write paragraphs in the patch subjects ;D

comment:2 by Dimitar Misev, 11 years ago

We need to make this regexp include new lines I think:

r = re.compile(r'\[PATCH[^\]]*\]( *\[[^\]]*\])* *(.*)', re.DOTALL)

comment:3 by abeccati, 11 years ago

Description: modified (diff)

And here comes the rationale for it:
http://git-scm.com/book/en/Distributed-Git-Contributing-to-a-Project#Commit-Guidelines

It looks like you should put entire chapters in a commit message :)

We can live with one liners but I hope someone can take this on so we can support more detail in commit messages.

comment:4 by Dimitar Misev, 11 years ago

Milestone: Future
Priority: criticalminor

comment:5 by Dimitar Misev, 11 years ago

A few sentences in a single paragraph at most is enough. For more use the ticket referenced in the commit message.

comment:6 by Dimitar Misev, 11 years ago

Component: undecidedpatch_manager

comment:7 by Dimitar Misev, 8 years ago

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.