Add textual comparison to systemtests (WCS et al)

[abeccati]

I have failing test with output that differs only for the endline mode (Win vs Lin). Weird since I am using Lin but get output in Win mode.

A robust way of dealing with that would be to add a textual comparison mode to the existing image and byte.

In RASSRC/systemtest/util/common.sh add case for when file is text to compare using "diff -w" which ignores all whitespace during the comparison.

PS: wanted to assign to nkolev but cannot find him in the users drop down

[Dimitar Misev]

I reassign it to you since you have a case to reproduce.

[Dimitar Misev]

I think it was fixed, Piero?

[Piero Campalani]

Yes:

$ grep diff ~/rasdaman/systemtest/util/common.sh 
          # diff comparison ignoring EOLs [see ticket #551]
          diff -b "$oracle" "$out" 2>&1 > /dev/null
$ git lg -S'diff -b' ~/rasdaman/systemtest/util/common.sh
...
* 17490d6 ticket:551 - Oracle match ignoring EOLs; drop EOL from multipoint oracles. | Piero Campalani | (2 weeks ago)

Maybe there is some portability problem… Alan which shell do you use?
I use bash and I have -b as option to ignore spaces, not -w.

$ bash --version | head -1
GNU bash, version 4.2.25(1)-release (x86_64-pc-linux-gnu)

[Dimitar Misev]

In my man diff I see

       -b, --ignore-space-change
              ignore changes in the amount of white space

       -w, --ignore-all-space
              ignore all white space

[Piero Campalani]

Yes here as well… I'm used to case-sensitive search in vim while man pages use less -is.
And we should ban commenting on the tickets in the weekend.

[abeccati]

I think the -w option is the more robust one to use since white space should not be relevant to the correctness of our output. If you think -b is enough then fine with me. Since I forgot to report version and test case I can no longer reproduce it so can be closed as fixed until we hit it again, if ever

PS: We should have a tickets comment party one of next summer week ends, from a nice green location and lots of beer, guess what could end up in tickets then

[abeccati]

Milestone 9.0-beta1 deleted