Opened 5 years ago
Closed 5 years ago
#2211 closed enhancement (fixed)
remove oid check from rasql generated by petascope
Reported by: | Dimitar Misev | Owned by: | Bang Pham Huu |
---|---|---|---|
Priority: | major | Milestone: | 10.0 |
Component: | petascope | Version: | 9.8 |
Keywords: | Cc: | Vlad Merticariu | |
Complexity: | Medium |
Description (last modified by )
All rasql queries generated by petascope have a WHERE clause like this:
WHERE oid(<coverage>) = <oid>
This is unnecessary as every coverage corresponds to a collection with a single object in it as far as I know. The WHERE clause should be removed to reduce clutter in the queries.
Change History (6)
comment:1 by , 5 years ago
Description: | modified (diff) |
---|
comment:2 by , 5 years ago
Cc: | added |
---|
comment:3 by , 5 years ago
comment:4 by , 5 years ago
It is enforced in petascope, so there's no problem as long as you don't fiddle with the coverage-collection directly in rasql.
It's annoying mostly because the rasql queries from the logs are not portable as is, requiring to always remove this WHERE clause before sharing.
comment:5 by , 5 years ago
Ok, makes sense for portability. We just need to make sure in InsertCoverage that the collection is empty (and I believe you're right that we do, in that a new collection is automatically created if something with the same name already exists).
comment:6 by , 5 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Having a single object per collection is a convention, but is not enforced. I don't see it as clutter, just a safety mechanism.