Opened 7 years ago

Closed 6 years ago

#1484 closed defect (fixed)

custom rasmgr port in start/stop_rasdaman.sh

Reported by: Dimitar Misev Owned by: Dimitar Misev
Priority: major Milestone: 9.4
Component: bin Version: development
Keywords: Cc: Peter Baumann
Complexity: Medium

Description

rasmgr and rascontrol calls in start_rasdaman.sh and stop_rasdaman.sh should use a --port $PORT variable set at the beginning of the script (to 7001 by default). It's annoying and error-prone to manually search where the port needs to be changed in these scripts.

Perhaps an even better solution is for this parameter to be specified in rasmgr.conf

Change History (9)

comment:1 by Bang Pham Huu, 7 years ago

Owner: changed from Bang Pham Huu to Dimitar Misev
Status: newassigned

comment:2 by Peter Baumann, 7 years ago

there as an idea of putting the port into rasmgr.conf - I like this approach because it concentrates information: rasserver ports are in rasmgr.conf already, too.

comment:3 by Dimitar Misev, 7 years ago

Should it be part of the define dbh command, e.g. option -port 7001 or so?

# define symbolic name for database host
# the MYHOST name is just a symbolic one, does not have to correspond with
# any name outside rasdaman; however, MUST NOT BE EQUAL to any other name used
# in this file!
# parameters:
#       -connect c      server connect information (RDBMS login, database
#                       name, or similar - depends on the base DBMS used;
#                       eg, can be "/" for Oracle, "RASBASE" for PostgreSQL)
define dbh rasdaman_host -connect RASBASE -port 7001

comment:4 by Peter Baumann, 7 years ago

in rasmgr/rasmgr_rascontrol_help.cc I find:

"define db 'dbname' -dbh 'dbhname'\r\n"
"       - define database 'dbname' on database host 'dbhname'\r\n"
"         ('dbname' is not a symbolic name, it is the real name of the rasdaman database
)\r\n"
"define host 'hostname' -net 'netaddress' [-port 'portnumber']\r\n"
"       - define server host with symbolic name 'hostname', located at address 'netaddress:portnumber'\r\n"
"         ('portnumber' defaults to 7001)\r\n"

…so done?

comment:5 by Dimitar Misev, 7 years ago

Perfect :)

But we are not done, we should put -port 7001 by default in rasmgr.conf and remove the specific port used in start_rasdaman.sh. This would mean upgrading rasmgr.conf somehow during install, which is hard and dangerous. We can either decide it's wontfix or try to devise some hazardous script for upgrading rasmgr.conf

comment:6 by Peter Baumann, 7 years ago

not sure it's worth the effort. We might just setup a how-to for portchanging which points to the places to be changed. It's just 2 I understand: start_rasdaman.sh and rasmgr.conf.

comment:7 by Dimitar Misev, 7 years ago

Actually I think we can safely remove it from start/stop_rasdaman.sh - they have 7001 as default anyway. Then if someone wants a different port, they can adapt rasmgr.conf

comment:8 by Peter Baumann, 7 years ago

sounds good, and as this script should not be updated by users anyway it is safer to replace/modify it during update.

comment:9 by Dimitar Misev, 6 years ago

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.