Opened 8 years ago
Closed 7 years ago
#1186 closed defect (fixed)
start_rasdaman.sh should have proper exit code
| Reported by: | George Merticariu | Owned by: | Bang Pham Huu |
|---|---|---|---|
| Priority: | minor | Milestone: | 10.0 |
| Component: | rasserver | Version: | development |
| Keywords: | Cc: | Peter Baumann | |
| Complexity: | Medium |
Description (last modified by )
start_rasdaman.sh should not attempt starting rasdaman if rasmgr is already running. Exit code 0 in this case.
start_rasdaman.sh should return a non-zero code (1) when it fails to start rasdaman.
stop_rasdaman.sh should wait until rasmgr is really down or a timeout (10 seconds) is reached. If the timeout is reached and rasmgr is still there it should exit with 1.
Change History (5)
comment:1 by , 8 years ago
| Component: | undecided → rasserver |
|---|---|
| Description: | modified (diff) |
| Milestone: | → 10.0 |
| Summary: | start_rasdaman should end successfully only if rasdaman starts correctly → start_rasdaman.sh should have proper exit code |
comment:2 by , 7 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:3 by , 7 years ago
| Description: | modified (diff) |
|---|
comment:4 by , 7 years ago
| Owner: | changed from to |
|---|
comment:5 by , 7 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Replying to gmerticariu:
start_rasdaman.sh should not attempt starting rasdaman if rasmgr is already running. Exit code 0 in this case.
it is correct.
start_rasdaman.sh start_rasdaman.sh: starting rasdaman server complex... nohup: appending output to ‘nohup.out’ start_rasdaman.sh: starting all rasdaman servers... start_rasdaman.sh: done. [rasdaman@gonzo rasdaman]$ echo $? 0 [rasdaman@gonzo rasdaman]$ start_rasdaman.sh start_rasdaman.sh: starting rasdaman server complex... nohup: appending output to ‘nohup.out’ start_rasdaman.sh: starting all rasdaman servers... start_rasdaman.sh: done. [rasdaman@gonzo rasdaman]$ echo $? 0
start_rasdaman.sh should return a non-zero code (1) when it fails to start rasdaman.
It is correct.
start_rasdaman.sh
start_rasdaman.sh: starting rasdaman server complex...
nohup: appending output to ‘nohup.out’
start_rasdaman.sh: starting all rasdaman servers...
start_rasdaman.sh: failed starting rasservers; please check the logs for more information.
start_rasdaman.sh: shutting down rasdaman... sleep: missing operand
Try 'sleep --help' for more information.
Could not execute command.
[rasdaman@gonzo rasdaman]$ echo $?
1
stop_rasdaman.sh should wait until rasmgr is really down or a timeout (10 seconds) is reached. If the timeout is reached and rasmgr is still there it should exit with 1.
cannot reproduce.
I think most of this has been fixed, but needs to be checked.