Opened 9 years ago
Closed 9 years ago
#1071 closed defect (fixed)
rasj.jar is not installed on make install
Reported by: | Dimitar Misev | Owned by: | Bang Pham Huu |
---|---|---|---|
Priority: | major | Milestone: | 9.1.x |
Component: | java | Version: | development |
Keywords: | Cc: | ||
Complexity: | Medium |
Description (last modified by )
rasj.jar should be installed to $RMANHOME/lib
Attachments (1)
Change History (13)
by , 9 years ago
Attachment: | 0001-rasj.jar-is-not-installed-on-make-install.patch added |
---|
follow-up: 3 comment:2 by , 9 years ago
Adding rasj in petascope dependencies is bad practice, since rasj is compiled differently for rnp and rasnet. The correct solution for this one is to put "java" folder as subdir for petascope. This way, "java" will be compiled before petascope and rasj.jar will be copied in the dependency list.
Add this line in Makefile.am in petascope and the issue will be fixed:
SUBDIRS=../../java
follow-up: 7 comment:3 by , 9 years ago
Replying to gmerticariu:
The correct solution for this one is to put "java" folder as subdir for petascope.
I think you should be more specific, you mean subdir in the Makefile.am SUBDIRS right?
follow-up: 8 comment:4 by , 9 years ago
This ticket is about installing rasj.jar into $RMANHOME/lib for example.
comment:5 by , 9 years ago
@Bang - rasj.jar has been added to .gitignore exactly because it shouldn't be pre-generated into the lib dir of petascope.
comment:6 by , 9 years ago
@Dimitar: year, I could understand from George's answer (as I don't know the reason before). What I would want to say here is for example: when clone new code, I could open project and doing instead of make or make install as it needs dependencies.
So as George said he could put "java" (this is a bit of confusing directory name) to Petascope properties then it does not complain with error when import.
comment:7 by , 9 years ago
Replying to dmisev:
Replying to gmerticariu:
The correct solution for this one is to put "java" folder as subdir for petascope.
I think you should be more specific, you mean subdir in the Makefile.am SUBDIRS right?
Yes, I put the command in my first comment.
comment:8 by , 9 years ago
Replying to dmisev:
This ticket is about installing rasj.jar into $RMANHOME/lib for example.
Is this a requirement? For rasj to be installed in the lib dir?
comment:9 by , 9 years ago
I don't know if it should be installed in the lib dir, or if there's some other standard installation place? But we need to distribute it somehow with RPMs for example, it's a library for Java clients.
comment:10 by , 9 years ago
Description: | modified (diff) |
---|---|
Owner: | changed from | to
Status: | new → assigned |
comment:11 by , 9 years ago
Owner: | changed from | to
---|
comment:12 by , 9 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Close ticket here as patch was accepted, thanks.