Opened 8 years ago

Closed 8 years ago

#1071 closed defect (fixed)

rasj.jar is not installed on make install

Reported by: Dimitar Misev Owned by: Bang Pham Huu
Priority: major Milestone: 9.1.x
Component: java Version: development
Keywords: Cc:
Complexity: Medium

Description (last modified by Dimitar Misev)

rasj.jar should be installed to $RMANHOME/lib

Attachments (1)

0001-rasj.jar-is-not-installed-on-make-install.patch (179.4 KB ) - added by Bang Pham Huu 8 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 by Bang Pham Huu, 8 years ago

Hey George,

Someone has added "applications/petascope/lib/rasj.jar" to ./gitignore

It should be added in petascope/lib/rasj.jar or when I open Petascope by Netbeans, it will have error with import class from org.odmg and rasj.

Do you mind if I upload this patch? (this has removed rasj.jar from gitignore).

http://www.rasdaman.org/attachment/ticket/1071/0001-rasj.jar-is-not-installed-on-make-install.patch

Last edited 8 years ago by Bang Pham Huu (previous) (diff)

comment:2 by George Merticariu, 8 years ago

Adding rasj in petascope dependencies is bad practice, since rasj is compiled differently for rnp and rasnet. The correct solution for this one is to put "java" folder as subdir for petascope. This way, "java" will be compiled before petascope and rasj.jar will be copied in the dependency list.

Add this line in Makefile.am in petascope and the issue will be fixed:

SUBDIRS=../../java

Last edited 8 years ago by George Merticariu (previous) (diff)

in reply to:  2 ; comment:3 by Dimitar Misev, 8 years ago

Replying to gmerticariu:

The correct solution for this one is to put "java" folder as subdir for petascope.

I think you should be more specific, you mean subdir in the Makefile.am SUBDIRS right?

comment:4 by Dimitar Misev, 8 years ago

This ticket is about installing rasj.jar into $RMANHOME/lib for example.

comment:5 by Dimitar Misev, 8 years ago

@Bang - rasj.jar has been added to .gitignore exactly because it shouldn't be pre-generated into the lib dir of petascope.

comment:6 by Bang Pham Huu, 8 years ago

@Dimitar: year, I could understand from George's answer (as I don't know the reason before). What I would want to say here is for example: when clone new code, I could open project and doing instead of make or make install as it needs dependencies.

So as George said he could put "java" (this is a bit of confusing directory name) to Petascope properties then it does not complain with error when import.

in reply to:  3 comment:7 by George Merticariu, 8 years ago

Replying to dmisev:

Replying to gmerticariu:

The correct solution for this one is to put "java" folder as subdir for petascope.

I think you should be more specific, you mean subdir in the Makefile.am SUBDIRS right?

Yes, I put the command in my first comment.

in reply to:  4 comment:8 by George Merticariu, 8 years ago

Replying to dmisev:

This ticket is about installing rasj.jar into $RMANHOME/lib for example.

Is this a requirement? For rasj to be installed in the lib dir?

comment:9 by Dimitar Misev, 8 years ago

I don't know if it should be installed in the lib dir, or if there's some other standard installation place? But we need to distribute it somehow with RPMs for example, it's a library for Java clients.

comment:10 by Dimitar Misev, 8 years ago

Description: modified (diff)
Owner: changed from George Merticariu to bphamhuuIt
Status: newassigned

comment:11 by Dimitar Misev, 8 years ago

Owner: changed from bphamhuuIt to Bang Pham Huu

comment:12 by Bang Pham Huu, 8 years ago

Resolution: fixed
Status: assignedclosed

Close ticket here as patch was accepted, thanks.

Note: See TracTickets for help on using tickets.