Opened 9 years ago
Closed 9 years ago
#1022 closed defect (fixed)
petascope files without header
Reported by: | Peter Baumann | Owned by: | Alex Dumitru |
---|---|---|---|
Priority: | critical | Milestone: | 9.1.x |
Component: | petascope | Version: | development |
Keywords: | Cc: | George Merticariu | |
Complexity: | Trivial |
Description
Several files, at least WCS-T files, do not have the obligatory header. This needs to be added.
Change History (11)
comment:1 by , 9 years ago
Component: | undecided → petascope |
---|
comment:2 by , 9 years ago
Cc: | added |
---|
comment:3 by , 9 years ago
it is every submitter's obligation to do that (and it has a legal meaning, so it cannot be just added by us), so add manually.
comment:4 by , 9 years ago
I think a range like 2003 - 2015 would be better than listing 15 years btw.
@Bang: there is already some script like that actually, have a look at source:applications/petascope/replace_license_headers.sh
comment:5 by , 9 years ago
Good point, Dimitar. I know that someone thought the same as me about this before (it is easy to add manually but also easy to forget and very hard to update each file to keep up with the current year of "Copy right" if doing like this). It will help a lot to maintain the consistency of all file headers and I will do it to make sure no file will be missed the file header before submit something. Thanks for your information.
comment:6 by , 9 years ago
this script was only done for checking the files initially coming from rasdaman GmbH and for some syntactic unification. Again, it is legal obligation for every submitter to provide files with the header. A submission without the header normally will get rejected right away. I have accepted the patch earlier _only_ in the expectation of an immediate followup patch, so please provide that right away.
comment:7 by , 9 years ago
@Prof. Peter: sorry, may I know which patch from which ticket (and the detail) you expect from me (as your comment reply to me - as you said 'provide that right away')?
comment:8 by , 9 years ago
Cc: | removed |
---|
see ticket title; AFAICS this affects commits by Vlad / Alex. They need to do it personally for "their" files. Therefore removing Bang + Dimitar from cc, to not pester them further.
And of course the benefit is no one will be asked again why this file is not have the header or the header is out of update like this (rasdaman/raslib/attribute.cc).