WCPS parser does not raise exception when parenthesis are missing

[Piero Campalani]

E.g. a correct WCPS coverageExpr:

for C in (mean_summer_airtemp) return 
    encode(
        scale(C,{
            x:"CRS:1"(0:127),
            y:"CRS:1"(0:156)
        }),
        "png"
    )

Same query + random removal of parenthesis:

for C in mean_summer_airtemp) return 
    encode(
        scale C,{
            x:"CRS:1"(0:127),
            y:"CRS:1"0:156)
    ),
    "png"

The output is identical.
The parser *does* notice this (logs), but no exception is thrown.

[Dimitar Misev]

Nice bug if you're lazy to type parenthesis

[Piero Campalani]

ahah…

[Dimitar Misev]

I've looked around and it seems like there's nothing much we can do to force it throw an error. I think it's just how antlr works, if it can still recognise the query it considers it fine. Even removing the for will work.. Removing in won't work though.

So I close it as won't fix because I think we can't do anything about it.

[Dimitar Misev]

Utkrist has accidentally discovered a way to fix this and make the grammar stricter.

I'm afraid it will break some existing queries/services (we discovered it as some queries in the systemtest erroneously have extra parentheses. So I'm not sure if we want to fix this now?

[Piero Campalani]

Accidentally discovered?
Wow.. Good shot Utkrist!

Imho, if this is not very hard like you (maybe accidentally again) set on this ticket, we should fix it: personally I feel safer to know that parenthesis checks are strict.

[Dimitar Misev]

changeset:0778878c62747608d2b8ee8fdfaaa215cdc32cbc