wcst_import - check SECORE URL from embedded petascope's port

[Bang Pham Huu]

In case, petascope runs in embedded port 9009 and SECORE runs in embedded port 9010 (in a system configured before)
with secore_urls=​http://localhost:9010/def in petascope.properties.

As def.war is now not deployed anymore as SECORE is a part of petascope as def.jar, wcst_import should check SECORE from embedded petascope as well by getting the port 9009 from service_url setting of ingredients files.

NOTE: if secore url is localhost (regardless of what port) and it doesn't exist on this port (e.g. 9010), then assume it's internal on service url (e.g: ​http://localhost:9009/rasdaman/def) and print a warning to fix it in petascope.properties.

[Dimitar Misev]

Why does it need to get port 9009 from petascope.properties, isn't the endpoint in the ingredients file?

Either way, it must print a warning, it shouldn't silently change the URL.

[Bang Pham Huu]

Why does it need to get port 9009 from petascope.properties, isn't the endpoint in the ingredients file?

No, SECORE endpoint doesn't need to exist in the ingredients files. In this case, wcst_import checks SECORE URLs from petascope.properties (that was your idea long time ago) and uses it.

it shouldn't silently change the URL

But, you said "assume it's "internal" " then it is still like what I wrote in the ticket description.

if secore url is localhost (regardless of what port) then assume it's "internal" + print a warning to fix it in petascope.properties?

[Dimitar Misev]

Replying to Bang Pham Huu:

No, SECORE endpoint doesn't need to exist in the ingredients files. In this case, wcst_import checks SECORE URLs from petascope.properties (that was your idea long time ago) and uses it.

I meant the petascope endpoint.. as you said "wcst_import should check SECORE from embedded petascope as well by getting the port 9009 in petascope.properties". Petascope endpoint (on port 9009) is in the ingredients.

But, you said "assume it's "internal" " then it is still like what I wrote in the ticket description.

"Assume it's internal" AND print a warning that it's making this assumption.. the quote from me below also says to print a warning, so I'm not sure what are you trying to "correct me".

When the user fixes petascope.properties → there will be no warning anymore.

if secore url is localhost (regardless of what port) then assume it's "internal" + print a warning to fix it in petascope.properties?