Changes between Initial Version and Version 2 of Ticket #1660


Ignore:
Timestamp:
Dec 19, 2017, 11:16:19 AM (7 years ago)
Author:
Dimitar Misev
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #1660

    • Property Status new → assigned
    • Property Cc Peter Baumann added
    • Property Component undecided → petascope
    • Property Milestone → 9.5
    • Property Owner set to Bang Pham Huu

  • Ticket #1660 – Description

    initial v2  
    1 I see too many of these logs, they should be blocked somehow (e.g. configure properly log4j of the libraries used in petascope):
     1The startup log can be improved, here's a suggestion: https://www.diffchecker.com/K2KSwtdk
     2
     3Below, 66 what? ms? I would word it as `rasql query executed in 66 ms.`
    24{{{
    3  TRACE [11:42:46] NioEventLoop@46: instrumented a special java.util.Set into: sun.nio.ch.EPollSelectorImpl@48c75380
    4  TRACE [11:42:46] NioEventLoop@46: instrumented a special java.util.Set into: sun.nio.ch.EPollSelectorImpl@7c56514a
    5  TRACE [11:42:46] NioEventLoop@46: instrumented a special java.util.Set into: sun.nio.ch.EPollSelectorImpl@d94fccf
    6  TRACE [11:42:46] NioEventLoop@46: instrumented a special java.util.Set into: sun.nio.ch.EPollSelectorImpl@133f59a9
    7  TRACE [11:42:46] NioEventLoop@46: instrumented a special java.util.Set into: sun.nio.ch.EPollSelectorImpl@6116531d
    8  TRACE [11:42:46] NioEventLoop@46: instrumented a special java.util.Set into: sun.nio.ch.EPollSelectorImpl@2f048274
    9 ...
     5 DEBUG [11:42:46] RasUtil@229: Total time for rasql: 66
    106}}}
     7
     8Here I see three identical logs for the rasql query basically. Only one is enough (RasUtil@142 I guess), the others should be removed:
     9{{{
     10 DEBUG [11:42:49] KVPWCSProcessCoverageHandler@114: Executing rasql query: SELECT encode(c[0:885,0:710], "png" , "{\"geoReference\":{\"crs\":\"EPSG:4326\",\"bbox\":{\"xmin\":111.975,\"ymin\":-44.525,\"xmax\":156.275,\"ymax\":-8.975}
     11}}") FROM test_mean_summer_airtemp AS c
     12 DEBUG [11:42:49] RasUtil@92: Execute rasql query 'SELECT encode(c[0:885,0:710], "png" , "{\"geoReference\":{\"crs\":\"EPSG:4326\",\"bbox\":{\"xmin\":111.975,\"ymin\":-44.525,\"xmax\":156.275,\"ymax\":-8.975}}}") FROM test_mean_summ
     13er_airtemp AS c'.
     14 TRACE [11:42:49] NioEventLoop@46: instrumented a special java.util.Set into: sun.nio.ch.EPollSelectorImpl@603a636e
     15 TRACE [11:42:49] NioEventLoop@46: instrumented a special java.util.Set into: sun.nio.ch.EPollSelectorImpl@591359e9
     16 TRACE [11:42:49] NioEventLoop@46: instrumented a special java.util.Set into: sun.nio.ch.EPollSelectorImpl@3fccc3a4
     17 TRACE [11:42:49] NioEventLoop@46: instrumented a special java.util.Set into: sun.nio.ch.EPollSelectorImpl@3d6abc0a
     18 TRACE [11:42:49] NioEventLoop@46: instrumented a special java.util.Set into: sun.nio.ch.EPollSelectorImpl@e7899da
     19 TRACE [11:42:49] NioEventLoop@46: instrumented a special java.util.Set into: sun.nio.ch.EPollSelectorImpl@4de745ed
     20 TRACE [11:42:49] NioEventLoop@46: instrumented a special java.util.Set into: sun.nio.ch.EPollSelectorImpl@146f6e16
     21 TRACE [11:42:49] NioEventLoop@46: instrumented a special java.util.Set into: sun.nio.ch.EPollSelectorImpl@7c0d1a7d
     22 TRACE [11:42:49] NioEventLoop@46: instrumented a special java.util.Set into: sun.nio.ch.EPollSelectorImpl@36f1ea6f
     23 TRACE [11:42:49] NioEventLoop@46: instrumented a special java.util.Set into: sun.nio.ch.EPollSelectorImpl@41ce0971
     24 TRACE [11:42:49] NioEventLoop@46: instrumented a special java.util.Set into: sun.nio.ch.EPollSelectorImpl@2e3ed080
     25 TRACE [11:42:49] NioEventLoop@46: instrumented a special java.util.Set into: sun.nio.ch.EPollSelectorImpl@3af4f9c8
     26 TRACE [11:42:49] NioEventLoop@46: instrumented a special java.util.Set into: sun.nio.ch.EPollSelectorImpl@3efce6b
     27 TRACE [11:42:49] NioEventLoop@46: instrumented a special java.util.Set into: sun.nio.ch.EPollSelectorImpl@32dbdae6
     28 TRACE [11:42:49] NioEventLoop@46: instrumented a special java.util.Set into: sun.nio.ch.EPollSelectorImpl@6ab9b6ed
     29 TRACE [11:42:49] NioEventLoop@46: instrumented a special java.util.Set into: sun.nio.ch.EPollSelectorImpl@771e28cb
     30 TRACE [11:42:49] RasUtil@142: Executing query SELECT encode(c[0:885,0:710], "png" , "{\"geoReference\":{\"crs\":\"EPSG:4326\",\"bbox\":{\"xmin\":111.975,\"ymin\":-44.525,\"xmax\":156.275,\"ymax\":-8.975}}}") FROM test_mean_summer_a
     31irtemp AS c
     32}}}
     33
     34There are too many of these logs, they should be blocked somehow (e.g. configure properly log4j of the libraries used in petascope):
     35{{{
     36 TRACE [11:42:49] NioEventLoop@46: instrumented a special java.util.Set into: sun.nio.ch.EPollSelectorImpl@771e28cb
     37 ...
     38 DEBUG [11:42:49] PoolThreadCache@81: Freed 1 thread-local buffer(s) from thread: threadDeathWatcher-3-2
     39}}}
     40There's duplication about the 'coverage id read from cache' (I think that log statement could be completely removed, it's not very useful at all):
     41{{{
     42 DEBUG [11:42:50] PetascopeController@90: Received request: coverageId=test_mean_summer_airtemp&format=image/png&request=GetCoverage&service=WCS&version=2.0.1
     43 DEBUG [11:42:50] AbstractHandler@90: Found the request handler: petascope.controller.handler.service.KVPWCSServiceHandler
     44 DEBUG [11:42:50] CoverageRepostioryService@119: Coverage id 'test_mean_summer_airtemp' is read from cache.
     45 DEBUG [11:42:50] ResponseService@128: Generated a single WCPS query from WCS request: for c in (test_mean_summer_airtemp) return encode(c[Lat(-44.525:-8.975), Long(111.975:156.275)], "png")
     46 DEBUG [11:42:50] CoverageRepostioryService@119: Coverage id 'test_mean_summer_airtemp' is read from cache.
     47}}}
     48
     49This should not be INFO:
     50{{{
     51  INFO [11:40:17] TypeRegistry@202: Succesfully initiated the type registry. Contents: {RGBSet...
     52}}}
     53best split it like this (notice also some fixed typos!):
     54{{{
     55  INFO [11:40:17] TypeRegistry@202: Successfully initialized the type registry.
     56  TRACE [11:40:17] TypeRegistry@202: Contents: {RGBSet...
     57}}}