Opened 2 years ago

Closed 5 months ago

#836 closed defect (fixed)

Change PetascopeInterface parent

Reported by: vmerticariu Owned by: bphamhuu
Priority: major Milestone: 9.3
Component: petascope Version: development
Keywords: Cc:
Complexity: Medium

Description

Refactor PetascopeInterface? to use the functionality for CORS request available in CORSHttpServlet class, once available.

Change History (13)

comment:1 Changed 2 years ago by dmisev

  • Component changed from undecided to petascope
  • Milestone set to 9.1

Vlad please set milestone and component when you open tickets!

comment:2 Changed 21 months ago by dmisev

can be closed?

comment:3 Changed 15 months ago by dmisev

  • Milestone changed from 9.1 to Future

comment:4 Changed 6 months ago by bphamhuu

  • Milestone changed from Future to 9.3
  • Owner changed from vmerticariu to bphamhuu
  • Status changed from new to assigned
  • Type changed from defect to enhancement

this is not fixed yet with change in PetascopeInterface? to "extends CORSHttpServlet", I think I will take it.

comment:5 Changed 6 months ago by bphamhuu

  • Resolution set to fixed
  • Status changed from assigned to closed

patch was accepted, close ticket.

comment:6 follow-up: Changed 5 months ago by mdumitru

  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Type changed from enhancement to defect

The patch broke CORS functionality.
You need to call super.doGet() in PetascopeInterface?.doGet() before doing anything else in the function

comment:7 in reply to: ↑ 6 Changed 5 months ago by bphamhuu

Replying to mdumitru:

The patch broke CORS functionality.
You need to call super.doGet() in PetascopeInterface?.doGet() before doing anything else in the function

cool, I will make a fix for it from your hint now.

comment:8 follow-up: Changed 5 months ago by dmisev

There was a test in the patch, what is it testing if not the CORS functionality??

comment:9 in reply to: ↑ 8 Changed 5 months ago by bphamhuu

Replying to dmisev:

There was a test in the patch, what is it testing if not the CORS functionality??

it simulate a request from a random host to Petascope and check in the HTTP header, it has the "Allow origin: *".

comment:10 follow-up: Changed 5 months ago by dmisev

But obviously that test doesn't work correctly if Alex says the CORS functionality is broken now.

comment:11 Changed 5 months ago by dmisev

I mean the test still passes, so it's incorrect.

comment:12 in reply to: ↑ 10 Changed 5 months ago by bphamhuu

Replying to dmisev:

But obviously that test doesn't work correctly if Alex says the CORS functionality is broken now.

ok, I will give more time to make the test correctly.

comment:13 Changed 5 months ago by bphamhuu

  • Resolution set to fixed
  • Status changed from reopened to closed

the patch was accepted, thanks.

Note: See TracTickets for help on using tickets.