Opened 4 years ago

Closed 21 months ago

#503 closed enhancement (fixed)

petascope_insertdemo.sh.in not to duplicate import statements

Reported by: pcampalani Owned by: bphamhuu
Priority: minor Milestone: 9.2
Component: undecided Version: development
Keywords: petascope_insertdemo.sh.in import_mst Cc: dmisev
Complexity: Easy

Description

The script for inserting the demo coverage in petascopedb (mean_summer_airtemp) should not duplicate the SQL statements which are already defined in the systemtest.
Since systemtest sources are not shipped with RPM installations, this means that the script containing the import function must be either moved or copied to $RMANHOME/lib or share or similar during installation.

$ grep FIXME ./applications/petascope/src/main/db/petascope_insertdemo.sh.in
$ grep import_mst ./systemtest//util/petascope.sh

Change History (5)

comment:1 Changed 4 years ago by pcampalani

Meanwhile, changeset:cce4a8 reintroduced the duplicate bash function (though now updated for ps9_* schema) to let the script work as expected.

comment:2 Changed 4 years ago by dmisev

#534 should be unified as well, we need common parsing of port, host and similar options.

comment:3 Changed 4 years ago by abeccati

  • Complexity changed from Medium to Easy
  • Priority changed from major to minor
  • Type changed from defect to enhancement
  • Version changed from 8.5 to development

I think the insert demo functions should be taken as reference from the system tests for the following reason (correct me if my assumption is wrong):
systemtests are only available when cloning from source and not in a packaged release while the insert demo is always delivered to the user. Given that assumption, we will always have deployed the insertdemo which can be sourced from the systemtests. The other way around will not work and rpm users will not have means for loading some demo data to play with and see how it is loaded.

Updating version since 8.5 is now in maintenance mode and this is more a dev issue to engineer for upcoming releases. Changed to easy since it seems suitable for a beginner with bash knowledge and some guidance

comment:4 Changed 21 months ago by bphamhuu

  • Owner changed from dmisev to bphamhuu
  • Status changed from new to assigned

I will change rasimport to wcst_import as in ticket 1137, so this ticket can be closed here.

comment:5 Changed 21 months ago by bphamhuu

  • Milestone changed from 9.0.x to 9.2
  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.