Opened 4 years ago

Closed 3 years ago

#483 closed enhancement (fixed)

editorial improvement of petascope.properties

Reported by: pbaumann Owned by: pcampalani
Priority: minor Milestone: 9.0
Component: petascope Version: 8.5
Keywords: inline documentation Cc: j.yu, nkolev
Complexity: Trivial

Description

Some inline documentation is not completely correct/understandable:

  • lines 47, 52, 57, 62: passwords should be adjusted, so change to "yes"
  • line 76: no description available, add
  • line 77: why need to adapt? config script should do that, if necessary; also, need to document what hapeens if version is wrong
  • line 82: don't see a need for adaptation -> "no"; also, add documentation of what happens on yes/no

Attachments (1)

petascope.properties (2.6 KB) - added by abeccati 4 years ago.
reference file for line numbers in ticket

Download all attachments as: .zip

Change History (6)

comment:1 Changed 4 years ago by abeccati

When using lines as reference please either attach your version of the document or specify git commit holding it otherwise these might just change by the time it gets addressed by other incoming commits.

Changed 4 years ago by abeccati

reference file for line numbers in ticket

comment:2 Changed 4 years ago by abeccati

  • Owner changed from abeccati to pcampalani
  • Status changed from new to assigned

Attached file for reference, can be factored into the feature branch merge or applied just after it.

comment:3 Changed 3 years ago by pcampalani

  • Cc j.yu nkolev added

All is ok, except we should clarify the XML validation issue.

That parameter in petascope.properties was introduced by Nikolche in changeset:e9e27d8, since beforehand we (developers) were manually disabling the XML schema load and request-validation: it was taking to much for Petascope to startup on the very first request after deployment.
On my machine around 30 secs:

...
INFO [10:24:40] ParsersRegistry@65: Registered parser petascope.wcs2.parsers.XMLGetCapabilitiesParser
INFO [10:25:10] ParsersRegistry@65: Registered parser petascope.wcs2.parsers.XMLDescribeCoverageParser
...

That patch from Nikolche, which btw has been accidentally reverted when I merged the feature_PetascopeSecore branch, made the XML input validation configurable in: petascope.wcs2.parsers.XMLDescribeCoverageParser.java.

Why there is schema validation of the input, and why only on a DescribeCoverage request? It involves OGC compliance: see #113.

Before I revert Nikolche's patch (and re-enable XML parsers which as well were commented out), do we want to have a more uniform behaviour on this side, that is enable input XML validation for any WCS request or why keeping it only for DescribeCoverage's ?

comment:4 Changed 3 years ago by pbaumann

excellent that you raise this question. We should strive for uniform behavior indeed, and changes in the interface (eg, config file syntax) need particular care and agreement. So let's discuss!

comment:5 Changed 3 years ago by pcampalani

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed in changeset:c6ea95c: as discussed the XML validation of input WCS request is now applied to all WCS requests, not only DescribeCoverage, and is turned off by default. It is however a recommended option on running services to ensure OGC compliance.

Note: See TracTickets for help on using tickets.