Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#269 closed defect (fixed)

Offset calculation in DbMetadataSource class is wrong

Reported by: dirk.daems@… Owned by: pcampalani
Priority: major Milestone: 8.4
Component: petascope Version: 8.3
Keywords: Cc:
Complexity:

Description

When the offset is not specified in the ps_crsdetails table it is calculated in the petascope.core.DbMetadataSource? class. However this calculation is not correct:

  if (o1 == null && o2 == null) {
    o1 = (h1 - l1) / (double) (x1 - x0);
    o2 = (h2 - l2) / (double) (y1 - y0);
    ...
  }

Should be:

  if (o1 == null && o2 == null) {
    o1 = (h1 - l1) / (double) (x1 - x0 + 1);
    o2 = (h2 - l2) / (double) (y1 - y0 + 1);
    ...
  }

Change History (5)

comment:1 Changed 5 years ago by dmisev

  • Owner changed from dmisev to pcampalani
  • Status changed from new to assigned

Thanks for reporting it Dirk, we'll look at it!

comment:2 Changed 5 years ago by pcampalani

We are probably talking about the problem fixed in:

commit 4a24f9539ff04491ca290cb98b2532b7af3fe3e1
Author: Piero Campalani <cmppri@unife.it>
Date:   Fri Dec 7 17:05:43 2012 +0100

    Fix resolution evaluation for coverages.

Dirk, please let us know if we can close this one.

comment:3 Changed 5 years ago by dmisev

In other words, please pull the latest rasdaman from the git repository.

comment:4 Changed 5 years ago by pcampalani

  • Resolution set to fixed
  • Status changed from assigned to closed

comment:5 Changed 5 years ago by dirk.daems@…

OK, seems to be fixed!

Note: See TracTickets for help on using tickets.