#1046 closed defect (fixed)

start_rasdaman messages

Reported by: mdumitru Owned by: mdumitru
Priority: major Milestone: 9.1.x
Component: undecided Version: development
Keywords: Cc: pbaumann, dmisev
Complexity: Medium

Description

The current messages when starting and stopping rasdaman are wrong. We should be clear in what is happening there.

E.g. stop_rasdaman.sh below, start_rasdaman.sh has similar issues

woland@gerald:/srv/protocol/bin$ ./stop_rasdaman.sh 

----------------Checking stopping Rasdaman Servers---------------- # this should be removed

stop_rasdaman.sh: terminating all rasdaman servers
stop_rasdaman.sh: terminating server N1...done.
stop_rasdaman.sh: terminating server N2...done.
stop_rasdaman.sh: terminating server N3...done.
stop_rasdaman.sh: terminating server N4...done.
stop_rasdaman.sh: terminating server N5...done.
stop_rasdaman.sh: terminating server N6...done.
stop_rasdaman.sh: terminating server N7...done.
stop_rasdaman.sh: terminating server N8...done.
stop_rasdaman.sh: terminating server N9...done.
terminating rasdaman server manager(s)...    rasmanager is shutting down. Good Bye! # the good bye should be removed
done.

Change History (14)

comment:1 Changed 17 months ago by pbaumann

agreed, we should restitute some discipline in the messages.
And, for conciseness: s/rasmanager/rasmgr

comment:2 Changed 17 months ago by bphamhuu

Regard to Alex's comment in here http://rasdaman.org/ticket/1042#comment:15, I would have some words:

----------------Checking stopping Rasdaman Servers---------------- # this should be removed


This line add to separate 2 terminations of Rasdaman Servers and embedded Jetty.
I think it is best to know which is checking to terminate and that is why you can see

----------------Checking stopping Rasdaman Servers----------------

stop_rasdaman.sh: terminating all rasdaman servers
stop_rasdaman.sh: terminating server N1...    Server N1 was killed
done.
stop_rasdaman.sh: terminating server N2...    Server N2 was killed


----------------Checking stopping embedded Petascope at PID = "3183"----

stop_rasdaman.sh: Terminate embedded Petascope successfully...Done.
stop_rasdaman.sh: done.


'

instead of

stop_rasdaman.sh: terminating all rasdaman servers
stop_rasdaman.sh: terminating server N1...    Server N1 was killed
done.
stop_rasdaman.sh: terminating server N2...    Server N2 was killed
done.
stop_rasdaman.sh: terminating server N3...    Server N3 was killed
done.
stop_rasdaman.sh: terminating server N4...    Server N4 was killed
done.
stop_rasdaman.sh: terminating server N5...    Server N5 was killed
done.
stop_rasdaman.sh: terminating server N6...    Server N6 was killed
done.
stop_rasdaman.sh: terminating server N7...    Server N7 was killed
done.
stop_rasdaman.sh: terminating server N8...    Server N8 was killed
done.
stop_rasdaman.sh: terminating server N9...    Server N9 was killed
done.
terminating rasdaman server manager(s)...    All hosts are down, bye
done.
Checking stopping embedded Petascope at PID = "3183"
stop_rasdaman.sh: Terminate embedded Petascope successfully...Done.
stop_rasdaman.sh: done.

Good Bye''' - I never seen this word in my stop_rasdaman.sh (how can you see this?).

comment:3 Changed 17 months ago by pbaumann

messages should be 1 line only per event, so no additional lines and no empty lines.

comment:4 Changed 17 months ago by bphamhuu

  • Resolution set to fixed
  • Status changed from new to closed

I would close this ticket as a patch (remove words as Alex mentioned) has been accepted and I will do as Prof. Peter want with messages from now.

comment:5 Changed 17 months ago by dmisev

  • Milestone set to 9.1.x
  • Resolution fixed deleted
  • Status changed from closed to reopened

I still see some empty lines -- all should be eliminated:

$ stop_rasdaman.sh 

stop_rasdaman.sh: terminating all rasdaman servers
stop_rasdaman.sh: terminating server N1...    Server N1 was killed
done.
stop_rasdaman.sh: terminating server P1...    Server P1 was killed
done.
terminating rasdaman server manager(s)...    All hosts are down.
done.

stop_rasdaman.sh: done.
$ start_rasdaman.sh 

start_rasdaman.sh: starting rasdaman server complex...
nohup: appending output to ‘nohup.out’
start_rasdaman.sh: starting all rasdaman servers...
    Started 2 servers on 1 hosts


start_rasdaman.sh: done.

comment:6 Changed 17 months ago by dmisev

Also the done. here seems extraneous and not necessary:

stop_rasdaman.sh: terminating server N1...    Server N1 was killed
done.

comment:7 Changed 17 months ago by pbaumann

"done" is good in that you know that no further step is pending. But ideally it should be on one line, following "...". However, due to the nested structure of output generation (and shell rules) this sometimes is difficult. Should be nice to find a solution, but we have more pressing issues. Let's see how far we get with limited effort!

comment:8 Changed 17 months ago by dmisev

I see "Server N1 was killed" equivalent to "done", so one of those is enough in the output I'd say.

comment:9 Changed 17 months ago by pbaumann

I agree. Reason for this is that a message should terminate with "." to show it's all done, and the "terminating" and "done" are coming from the script while the "was killed" comes from another place (hence the blanks and newline). We could shorten this to just "." instead of "done." but I find lines only containing a dot not very instructive either.
No idea, though, how to get rid of the newline without major work in different places (rascontrol and all tools forwarding the messages).

Last edited 17 months ago by pbaumann (previous) (diff)

comment:10 Changed 17 months ago by bphamhuu

@Dimitar: I will do as you request from blank line to "done.". In fact, I like this message like this "Terminating server N1...Done." (as I don't like the word "killed").

comment:11 Changed 17 months ago by pbaumann

be careful with changing! Manual says "kill", see there why.
You could pipe rascontrol output for filtering to get rid of newline etc, but again: is it worth the effort? Which essential fix could we have done meantime?

comment:12 Changed 17 months ago by dmisev

I think this output is only from the old rasmgr, in the new one as can be seen in Alex's quote in the ticket description it looks ok. So just remove the empty lines and we can close the ticket.

comment:13 Changed 17 months ago by bphamhuu

This has been done in meantime with my little effort but it is up to you to accept or not http://codereview.rasdaman.org/D15

comment:14 Changed 16 months ago by bphamhuu

  • Resolution set to fixed
  • Status changed from reopened to closed

patch has been accepted, I will close it, thanks.

Note: See TracTickets for help on using tickets.