#1022 closed defect (fixed)

petascope files without header

Reported by: pbaumann Owned by: mdumitru
Priority: critical Milestone: 9.1.x
Component: petascope Version: development
Keywords: Cc: gmerticariu
Complexity: Trivial

Description

Several files, at least WCS-T files, do not have the obligatory header. This needs to be added.

Change History (11)

comment:1 Changed 20 months ago by pbaumann

  • Component changed from undecided to petascope

comment:2 Changed 19 months ago by bphamhuu

  • Cc bphamhuu dmisev added

I can do this task (suppose it has not been finished ?). In fact, I suggest we should make a tool based on shell script to:

+ Update the file header of each file (I suppose copyright should from 2003 to 2015) instead of

* Copyright 2003, 2004, 2005, 2006, 2007, 2008, 2009 Peter Baumann /
rasdaman GmbH.

. So each year some one can run this tool to add the new header to all files.

+ Developers don't need to add this header by hand every create a new file. Make every thing done and run this tool with the input folder is application folder.

If Prof. Peter like my idea, I will start to do it in next week.

And of course the benefit is no one will be asked again why this file is not have the header or the header is out of update like this (rasdaman/raslib/attribute.cc).

/*
* This file is part of rasdaman community.
*
* Rasdaman community is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* Rasdaman community is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with rasdaman community.  If not, see <http://www.gnu.org/licenses/>.
*
* Copyright 2003, 2004, 2005, 2006, 2007, 2008, 2009 Peter Baumann /
rasdaman GmbH.
*
* For more information please see <http://www.rasdaman.org>
* or contact Peter Baumann via <baumann@rasdaman.com>.
*/

comment:3 Changed 19 months ago by pbaumann

it is every submitter's obligation to do that (and it has a legal meaning, so it cannot be just added by us), so add manually.

comment:4 Changed 19 months ago by dmisev

I think a range like 2003 - 2015 would be better than listing 15 years btw.

@Bang: there is already some script like that actually, have a look at source:applications/petascope/replace_license_headers.sh

comment:5 Changed 19 months ago by bphamhuu

Good point, Dimitar. I know that someone thought the same as me about this before (it is easy to add manually but also easy to forget and very hard to update each file to keep up with the current year of "Copy right" if doing like this). It will help a lot to maintain the consistency of all file headers and I will do it to make sure no file will be missed the file header before submit something. Thanks for your information.

comment:6 Changed 19 months ago by pbaumann

this script was only done for checking the files initially coming from rasdaman GmbH and for some syntactic unification. Again, it is legal obligation for every submitter to provide files with the header. A submission without the header normally will get rejected right away. I have accepted the patch earlier _only_ in the expectation of an immediate followup patch, so please provide that right away.

comment:7 Changed 19 months ago by bphamhuu

@Prof. Peter: sorry, may I know which patch from which ticket (and the detail) you expect from me (as your comment reply to me - as you said 'provide that right away')?

comment:8 Changed 19 months ago by pbaumann

  • Cc bphamhuu dmisev removed

see ticket title; AFAICS this affects commits by Vlad / Alex. They need to do it personally for "their" files. Therefore removing Bang + Dimitar from cc, to not pester them further.

comment:9 Changed 19 months ago by pbaumann

when about will the headers be added?

comment:10 Changed 19 months ago by mdumitru

Almost done with them, I will commit today.

comment:11 Changed 19 months ago by mdumitru

  • Resolution set to fixed
  • Status changed from new to closed

patch accepted

Note: See TracTickets for help on using tickets.